Fix rate remaining header value for Redis repository #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge marcosbarbero:master
Master merge
merge master branch
Conflicts: spring-cloud-zuul-ratelimit-core/src/main/java/com/marcosbarbero/cloud/autoconfigure/zuul/ratelimit/config/repository/RedisRateLimiter.java spring-cloud-zuul-ratelimit-core/src/test/java/com/marcosbarbero/cloud/autoconfigure/zuul/ratelimit/config/repository/RedisRateLimiterTest.java
Merge master
merge master
Bump infinispan.version from 10.0.1.Final to 10.1.0.Final (#271)
marcosbarbero
previously approved these changes
Jan 13, 2020
marcosbarbero
previously approved these changes
Jan 13, 2020
|
For some reason, Travis is not breaking in the IT tests, but the test on Scroll all the way down to the bottom of the raw logs and you'll see it. |
|
It fails because I used an existing service path in my test. So if my test runs before testNotExceedingCapacityRequest test, the limit refresh interval did not end and we get 429. This failure depends on the order of execution. You ca reproduce it by commenting all the tests except testNotExceedingCapacityRequest and testShouldReturnCorrectRateRemainingValue. |
marcosbarbero
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #273
Changes proposed in this pull request: