Bug 1435155 - Redact the shipping address as it is visible before the…

… promise from PaymentRequest.show() resolves successfully. r=baku

Spec PR: w3c/payment-request#654

MozReview-Commit-ID: 2AiKI7htRhk

UltraBlame original commit: 8a29a154e88dc58d0ffde543a2159d70638ce53c

dom/payments/PaymentRequest.cpp

@@ -4735,6 +4735,59 @@ aRv
 return
 ;
 }
+/
+/
+When
+the
+user
+agent
+has
+opted
+to
+redact
+the
+shipping
+address
+/
+/
+in
+earlier
+steps
+the
+spec
+doesn
+'
+t
+update
+the
+request
+with
+/
+/
+the
+unredacted
+address
+at
+this
+point
+.
+Maybe
+to
+reduce
+the
+/
+/
+number
+of
+footguns
+it
+should
+(
+without
+an
+event
+)
+.
 RefPtr
 <
 PaymentResponse
@@ -4751,7 +4804,7 @@ mInternalId
 mId
 aMethodName
 mShippingOption
-mShippingAddress
+mFullShippingAddress
 aDetails
 aPayerName
 aPayerEmail
@@ -5663,6 +5716,12 @@ nsAString
 aPhone
 )
 {
+nsTArray
+<
+nsString
+>
+emptyArray
+;
 mShippingAddress
 =
 new
@@ -5672,6 +5731,33 @@ GetOwner
 (
 )
 aCountry
+emptyArray
+aRegion
+aCity
+aDependentLocality
+aPostalCode
+aSortingCode
+aLanguageCode
+EmptyString
+(
+)
+EmptyString
+(
+)
+EmptyString
+(
+)
+)
+;
+mFullShippingAddress
+=
+new
+PaymentAddress
+(
+GetOwner
+(
+)
+aCountry
 aAddressLine
 aRegion
 aCity

dom/payments/PaymentRequest.h

@@ -861,14 +861,8 @@ mResponse
 ;
 /
 /
-It
-is
-populated
-when
-the
-user
-provides
-a
+The
+redacted
 shipping
 address
 .
@@ -880,6 +874,27 @@ mShippingAddress
 ;
 /
 /
+The
+full
+shipping
+address
+to
+be
+used
+in
+the
+response
+upon
+payment
+.
+RefPtr
+<
+PaymentAddress
+>
+mFullShippingAddress
+;
+/
+/
 It
 is
 populated

dom/payments/test/ShowPaymentChromeScript.js

@@ -251,6 +251,8 @@ Bruno
 /
 city
 "
+Test
+locality
 "
 /
 /
@@ -278,6 +280,8 @@ en
 language
 code
 "
+Testing
+Org
 "
 /
 /