Skip to content

Commit

Permalink
Bug 1642484 [wpt PR 23900] - Remove MainThreadScrollingReasons::kHasC…
Browse files Browse the repository at this point in the history
…lipRelatedProperty, a=testonly

Automatic update from web-platform-tests
Remove MainThreadScrollingReasons::kHasClipRelatedProperty

We no longer need to skip composited scrolling for css clip and
clip-path since (perhaps) BlinkGenPropertyTrees.

In compositor, when we hit test on a layer with special clip/mask,
we'll still fallback to main thread hit testing/scrolling because only
the main thread knows which area is hit testable. This is achieved by
 cc::LayerTreeHostImpl::IsInitialScrollHitTestReliable() returning false.

Bug: 1074395
Change-Id: I91260b063879812ca82928fe783de25c4b6732a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225229
Commit-Queue: Xianzhu Wang <wangxianzhuchromium.org>
Reviewed-by: Philip Rogers <pdrchromium.org>
Reviewed-by: Robert Flack <flackrchromium.org>
Reviewed-by: David Bokan <bokanchromium.org>
Cr-Commit-Position: refs/heads/master{#774232}

--

wpt-commits: 4c2484a55b58a72b74c0b6c55ab0238cf11efb4a
wpt-pr: 23900

Differential Revision: https://phabricator.services.mozilla.com/D78793

UltraBlame original commit: f3c2bc8c1eb7f797acd6f0b036e4019332e6c6b3
  • Loading branch information
marco-c committed Jun 11, 2020
1 parent f2353a6 commit c1b59df
Show file tree
Hide file tree
Showing 4 changed files with 691 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,272 @@
<
!
DOCTYPE
html
>
<
title
>
CSS
Masking
:
Test
clip
-
path
property
with
overflow
:
scroll
<
/
title
>
<
link
rel
=
"
help
"
href
=
"
http
:
/
/
www
.
w3
.
org
/
TR
/
css
-
masking
-
1
/
#
clip
-
path
-
property
"
>
<
link
rel
=
"
match
"
href
=
"
reference
/
clip
-
path
-
scroll
-
ref
.
html
"
>
<
html
class
=
"
reftest
-
wait
"
>
<
p
>
The
test
passes
if
there
is
a
green
square
containing
text
(
which
can
be
scrolled
with
mouse
wheel
or
touch
)
.
No
scrollbars
should
be
seen
.
<
/
p
>
<
div
id
=
"
target
"
style
=
"
clip
-
path
:
polygon
(
10px
10px
10px
100px
100px
100px
100px
10px
)
;
width
:
200px
;
height
:
200px
;
overflow
:
scroll
;
background
:
red
"
>
<
div
style
=
"
position
:
relative
;
top
:
100px
;
width
:
100px
;
height
:
100px
;
background
:
green
"
>
<
/
div
>
<
div
style
=
"
height
:
1000px
"
>
<
/
div
>
<
/
div
>
<
script
>
requestAnimationFrame
(
(
)
=
>
{
requestAnimationFrame
(
(
)
=
>
{
target
.
scrollTop
=
100
;
document
.
documentElement
.
classList
.
remove
(
"
reftest
-
wait
"
)
;
}
)
;
}
)
;
<
/
script
>
<
/
html
>
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
<
!
DOCTYPE
html
>
<
p
>
The
test
passes
if
there
is
a
green
square
containing
text
(
which
can
be
scrolled
with
mouse
wheel
or
touch
)
.
No
scrollbars
should
be
seen
.
<
/
p
>
<
div
style
=
"
position
:
relative
;
top
:
10px
;
left
:
10px
;
width
:
90px
;
height
:
90px
;
background
:
green
"
>
<
/
div
>
Loading

0 comments on commit c1b59df

Please sign in to comment.