Skip to content

Commit

Permalink
Bug 1404917 - Move image preview tooltip to file name and remove prev…
Browse files Browse the repository at this point in the history
…iew icon. r=Honza

MozReview-Commit-ID: 86YPdHZhCmo

UltraBlame original commit: e1515b5c14e299553098c78fd79c0e735602875d
  • Loading branch information
marco-c committed Oct 2, 2019
1 parent 0327cc5 commit 89fb0d0
Show file tree
Hide file tree
Showing 12 changed files with 22 additions and 971 deletions.
46 changes: 0 additions & 46 deletions devtools/client/netmonitor/src/assets/styles/RequestList.css
Original file line number Diff line number Diff line change
Expand Up @@ -1695,52 +1695,6 @@ requests
-
list
-
icon
{
background
:
transparent
;
width
:
15px
;
height
:
15px
;
margin
:
0
4px
;
outline
:
1px
solid
var
(
-
-
table
-
splitter
-
color
)
;
vertical
-
align
:
top
;
}
.
requests
-
list
-
protocol
{
width
Expand Down
33 changes: 0 additions & 33 deletions devtools/client/netmonitor/src/components/RequestListColumnFile.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ utils
const
{
div
img
}
=
DOM
Expand All @@ -57,9 +56,6 @@ UPDATED_FILE_PROPS
=
[
"
responseContentDataUri
"
"
urlDetails
"
]
Expand All @@ -84,13 +80,6 @@ PropTypes
object
.
isRequired
onThumbnailMouseDown
:
PropTypes
.
func
.
isRequired
}
;
}
Expand Down Expand Up @@ -124,10 +113,8 @@ let
item
:
{
responseContentDataUri
urlDetails
}
onThumbnailMouseDown
}
=
this
Expand Down Expand Up @@ -159,26 +146,6 @@ urlDetails
.
unicodeUrl
}
img
(
{
className
:
"
requests
-
list
-
icon
"
src
:
responseContentDataUri
onMouseDown
:
onThumbnailMouseDown
}
)
urlDetails
.
baseNameWithQuery
Expand Down
44 changes: 1 addition & 43 deletions devtools/client/netmonitor/src/components/RequestListContent.js
Original file line number Diff line number Diff line change
Expand Up @@ -269,13 +269,6 @@ PropTypes
func
.
isRequired
onThumbnailMouseDown
:
PropTypes
.
func
.
isRequired
onWaterfallMouseDown
:
PropTypes
Expand Down Expand Up @@ -790,11 +783,6 @@ props
;
if
(
requestItem
.
responseContent
&
&
target
.
closest
Expand All @@ -805,7 +793,7 @@ requests
-
list
-
icon
file
"
)
)
Expand Down Expand Up @@ -1009,7 +997,6 @@ firstRequestStartedMillis
onCauseBadgeMouseDown
onItemMouseDown
onSecurityIconMouseDown
onThumbnailMouseDown
onWaterfallMouseDown
scale
selectedRequestId
Expand Down Expand Up @@ -1195,15 +1182,6 @@ item
.
securityState
)
onThumbnailMouseDown
:
(
)
=
>
onThumbnailMouseDown
(
)
onWaterfallMouseDown
:
(
Expand Down Expand Up @@ -1387,26 +1365,6 @@ selectDelta
delta
)
)
onThumbnailMouseDown
:
(
)
=
>
{
dispatch
(
Actions
.
selectDetailsPanelTab
(
"
response
"
)
)
;
}
onWaterfallMouseDown
:
(
Expand Down
9 changes: 0 additions & 9 deletions devtools/client/netmonitor/src/components/RequestListItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -540,13 +540,6 @@ PropTypes
func
.
isRequired
onThumbnailMouseDown
:
PropTypes
.
func
.
isRequired
onWaterfallMouseDown
:
PropTypes
Expand Down Expand Up @@ -701,7 +694,6 @@ onContextMenu
onMouseDown
onCauseBadgeMouseDown
onSecurityIconMouseDown
onThumbnailMouseDown
onWaterfallMouseDown
}
=
Expand Down Expand Up @@ -837,7 +829,6 @@ RequestListColumnFile
(
{
item
onThumbnailMouseDown
}
)
columns
Expand Down
48 changes: 0 additions & 48 deletions devtools/client/netmonitor/src/connector/chrome/response.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,28 +3,6 @@ use
strict
"
;
const
{
formDataURI
}
=
require
(
"
.
.
/
.
.
/
utils
/
request
-
utils
"
)
;
function
ResponseInfo
(
Expand Down Expand Up @@ -102,7 +80,6 @@ content
const
{
body
base64Encoded
}
=
content
Expand Down Expand Up @@ -154,31 +131,6 @@ mimeType
body
)
;
if
(
mimeType
.
includes
(
"
image
/
"
)
)
{
payload
.
responseContentDataUri
=
formDataURI
(
mimeType
base64Encoded
response
)
;
}
return
payload
;
Expand Down
27 changes: 0 additions & 27 deletions devtools/client/netmonitor/src/connector/firefox-data-provider.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ curl
const
{
fetchHeaders
formDataURI
}
=
require
Expand Down Expand Up @@ -344,7 +343,6 @@ content
{
let
{
encoding
text
}
=
Expand All @@ -363,31 +361,6 @@ getLongString
text
)
;
if
(
mimeType
.
includes
(
"
image
/
"
)
)
{
payload
.
responseContentDataUri
=
formDataURI
(
mimeType
encoding
response
)
;
}
responseContent
.
content
Expand Down
3 changes: 0 additions & 3 deletions devtools/client/netmonitor/src/reducers/requests.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,6 @@ undefined
responseContentAvailable
:
false
responseContentDataUri
:
undefined
formDataSections
:
undefined
Expand Down
Loading

0 comments on commit 89fb0d0

Please sign in to comment.