fix: Proper support for keyboard navigation for Radio #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
fix/compositor-outer-border-rendering
to
main
September 13, 2024 20:32
marc2332
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
==========================================
- Coverage 76.04% 75.99% -0.06%
==========================================
Files 205 205
Lines 23235 23244 +9
==========================================
- Hits 17670 17664 -6
- Misses 5565 5580 +15 ☔ View full report in Codecov by Sentry. |
Closed
Tropix126
pushed a commit
to Tropix126/freya
that referenced
this pull request
Sep 15, 2024
* fix: Proper incremental redraws for elements with outer or center borders * chore: torin changes * feat: Proper support for keyboard navigation with Radio * fix: Update tests * chore: Update tests
Closed
marc2332
added a commit
that referenced
this pull request
Oct 6, 2024
* feat: add attributes for most AccessKit properties * fix: update components * fix: tests * fix `NodeBuilder` unwrap assumption * fix: Proper support for keyboard navigation for Radio (#880) * fix: Proper incremental redraws for elements with outer or center borders * chore: torin changes * feat: Proper support for keyboard navigation with Radio * fix: Update tests * chore: Update tests * feat: Only focus focusable nodes * chore: Update tests * chore: Update tests * feat: add attributes for most AccessKit properties * fix: update components * fix: tests * revert components changes * fix accessibility nodes not being added to tree * feat: use inner text for `paragraph`/`label` names if none is provided * fix accessibility tests * fmt, lint * reduce out-of-scope changes * fmt * refactor: make `a11y_role` attribute kebab case * lint * fmt again * fix bad accessibility state merge * use `Role::parse` rather than `serde_json` * fix bad role in test * fix role parsing test * update or remove redundant roles from components --------- Co-authored-by: Marc Espin <[email protected]>
marc2332
added a commit
that referenced
this pull request
Oct 6, 2024
* feat: add attributes for most AccessKit properties * fix: update components * fix: tests * fix `NodeBuilder` unwrap assumption * fix: Proper support for keyboard navigation for Radio (#880) * fix: Proper incremental redraws for elements with outer or center borders * chore: torin changes * feat: Proper support for keyboard navigation with Radio * fix: Update tests * chore: Update tests * feat: Only focus focusable nodes * chore: Update tests * chore: Update tests * feat: add attributes for most AccessKit properties * fix: update components * fix: tests * revert components changes * fix accessibility nodes not being added to tree * feat: use inner text for `paragraph`/`label` names if none is provided * fix accessibility tests * fmt, lint * reduce out-of-scope changes * fmt * refactor: make `a11y_role` attribute kebab case * lint * fmt again * fix bad accessibility state merge * use `Role::parse` rather than `serde_json` * fix bad role in test * fix role parsing test * update or remove redundant roles from components * feat: Parent & children-based accessibility nodes relations --------- Co-authored-by: Tropical <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #879