Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: a11y_auto_focus #878

Merged
merged 5 commits into from
Sep 13, 2024
Merged

feat: a11y_auto_focus #878

merged 5 commits into from
Sep 13, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Sep 12, 2024

This is a much better altenative to the previous queued focus.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 70.52632% with 28 lines in your changes missing coverage. Please review.

Project coverage is 76.10%. Comparing base (a92983a) to head (39f19dd).

Files with missing lines Patch % Lines
crates/renderer/src/accessibility.rs 0.00% 12 Missing ⚠️
crates/renderer/src/app.rs 0.00% 12 Missing ⚠️
crates/common/src/accessibility.rs 75.00% 1 Missing ⚠️
crates/components/src/hooks/use_form.rs 0.00% 1 Missing ⚠️
crates/renderer/src/renderer.rs 0.00% 1 Missing ⚠️
crates/state/src/accessibility.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   76.03%   76.10%   +0.06%     
==========================================
  Files         205      205              
  Lines       23152    23207      +55     
==========================================
+ Hits        17604    17662      +58     
+ Misses       5548     5545       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit 13f67c5 into main Sep 13, 2024
7 checks passed
@marc2332 marc2332 deleted the feat/a11y-auto-focus branch September 13, 2024 20:32
@marc2332 marc2332 mentioned this pull request Sep 13, 2024
22 tasks
This was referenced Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant