Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ergonomic improvements in ScrollView #858

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Sep 9, 2024

Both ScrollView and VirtualScrollView no longer use a theme for the width, height, padding and spacing. And now, both of them can shrink to the size of its children size in the axis direction when that is "auto". So for example you can make a vertical ScrollView shrink to its inner children size by specifying a width: "auto"

Closes #857

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Sep 9, 2024
@marc2332 marc2332 self-assigned this Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 93.49593% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.98%. Comparing base (394774b) to head (8da6880).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...components/src/scroll_views/virtual_scroll_view.rs 91.66% 5 Missing ⚠️
crates/components/src/scroll_views/mod.rs 86.66% 2 Missing ⚠️
crates/components/src/scroll_views/scroll_view.rs 97.91% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   75.95%   75.98%   +0.02%     
==========================================
  Files         205      205              
  Lines       22974    23017      +43     
==========================================
+ Hits        17450    17489      +39     
- Misses       5524     5528       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit d76e12a into main Sep 11, 2024
7 checks passed
@marc2332 marc2332 deleted the feat/ergonomic-improvements-scroll-view branch September 11, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Support fitting scroll views size in the cross axis
1 participant