Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opengl_rtt example. #813

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Add opengl_rtt example. #813

merged 6 commits into from
Aug 30, 2024

Conversation

hellozyemlya
Copy link
Contributor

@hellozyemlya hellozyemlya commented Aug 10, 2024

  • wraps parameters of CanvasRunner to struct, just in case more rendering information will be passed in future
  • adds simple opengl_rtt example:
    • messing with raw opengl to render triangle
    • renders to texture
    • using raw opengl texture to draw on skia canvas

@hellozyemlya hellozyemlya requested a review from marc2332 as a code owner August 10, 2024 16:25
@marc2332 marc2332 added the enhancement 🔥 New feature or request label Aug 10, 2024
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 88 lines in your changes missing coverage. Please review.

Project coverage is 73.79%. Comparing base (de6d87c) to head (c8684d8).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/components/src/graph.rs 0.00% 81 Missing ⚠️
crates/core/src/elements/rect.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
- Coverage   73.81%   73.79%   -0.03%     
==========================================
  Files         201      201              
  Lines       21530    21537       +7     
==========================================
  Hits        15893    15893              
- Misses       5637     5644       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks nice! I'll try it asap. Nice work! and sorry for the delay

@marc2332 marc2332 merged commit d87a932 into marc2332:main Aug 30, 2024
4 of 5 checks passed
This was referenced Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants