Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add performance-overlay feature to freya crate #809

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Aug 7, 2024

Closes #490

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Benchmark for 88827fb

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 108.8±0.42ms 108.9±0.91ms +0.09%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 25.6±1.17ms 25.1±0.93ms -1.95%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1477.6±38.41µs 1474.2±8.36µs -0.23%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 143.2±1.15µs 141.8±1.46µs -0.98%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.4±0.82ms 24.3±0.32ms -0.41%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1742.4±39.55µs 1730.2±8.12µs -0.70%
benchmarks/size=19531 depth=7 wide=5 mode=cached 310.1±3.34µs 308.9±3.90µs -0.39%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.7±0.17ms 2.7±0.11ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 426.3±107.04µs 427.6±146.09µs +0.30%
benchmarks/size=54241 depth=5 wide=15 mode=cached 247.5±12.49µs 281.1±132.62µs +13.58%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.7±0.08ms 6.6±0.07ms -1.49%

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (de6d87c) to head (6ec523f).

Files Patch % Lines
crates/freya/src/launch.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
- Coverage   73.81%   73.80%   -0.02%     
==========================================
  Files         201      201              
  Lines       21530    21533       +3     
==========================================
  Hits        15893    15893              
- Misses       5637     5640       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit b872e5b into main Aug 10, 2024
7 of 8 checks passed
@marc2332 marc2332 deleted the feat/performance-overlay-feature branch August 10, 2024 15:44
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Enable the Performance Plugin with performance-overlay feature
1 participant