Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow custom Tokio Runtimes #765

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jul 6, 2024

No description provided.

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jul 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

Benchmark for 9735f73

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 109.8±1.59ms 109.6±1.64ms -0.18%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 25.1±1.07ms 25.9±1.22ms +3.19%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1437.1±15.58µs 1461.8±15.53µs +1.72%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 140.3±2.25µs 141.8±7.41µs +1.07%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.3±1.78ms 24.6±0.92ms -2.77%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1771.7±114.63µs 1782.0±149.30µs +0.58%
benchmarks/size=19531 depth=7 wide=5 mode=cached 375.2±42.98µs 333.9±29.98µs -11.01%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.9±0.25ms 2.7±0.17ms -6.90%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 421.3±78.79µs 419.7±74.70µs -0.38%
benchmarks/size=54241 depth=5 wide=15 mode=cached 310.0±84.12µs 296.9±207.59µs -4.23%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.8±0.50ms 6.8±0.59ms 0.00%

Copy link

github-actions bot commented Jul 6, 2024

Benchmark for 3ee87f8

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 108.4±0.37ms 109.4±0.43ms +0.92%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 23.9±0.43ms 23.8±0.94ms -0.42%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1428.6±8.49µs 1449.1±19.40µs +1.43%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 140.6±1.67µs 141.3±3.31µs +0.50%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.0±1.21ms 23.1±0.44ms -3.75%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1748.3±122.83µs 1785.0±41.94µs +2.10%
benchmarks/size=19531 depth=7 wide=5 mode=cached 309.8±3.72µs 329.1±13.83µs +6.23%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.01ms 2.7±0.04ms +3.85%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 419.8±135.45µs 421.7±130.31µs +0.45%
benchmarks/size=54241 depth=5 wide=15 mode=cached 249.5±18.92µs 244.5±9.94µs -2.00%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.5±0.06ms 6.6±0.11ms +1.54%

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.65%. Comparing base (1955629) to head (6671500).

Files Patch % Lines
crates/freya/src/launch.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
- Coverage   73.66%   73.65%   -0.01%     
==========================================
  Files         199      199              
  Lines       20377    20379       +2     
==========================================
  Hits        15011    15011              
- Misses       5366     5368       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review July 8, 2024 17:42
@marc2332 marc2332 merged commit 1fbd19d into main Jul 9, 2024
4 of 5 checks passed
@marc2332 marc2332 deleted the feat/allow-custom-tokio-runtimes branch July 9, 2024 19:58
This was referenced Jul 9, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant