Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent opacity from clipping the node bounds #764

Merged
merged 7 commits into from
Jul 13, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jul 6, 2024

Closes #762

@marc2332 marc2332 added the fix 🩹 Fixes a bug label Jul 6, 2024
@marc2332 marc2332 self-assigned this Jul 6, 2024
@marc2332
Copy link
Owner Author

marc2332 commented Jul 6, 2024

idea: Prepare shadows, adjust node bounds with the shadows bounds and then apply the opacity on the adjusted bounds

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 73.74%. Comparing base (1cfd863) to head (c1f57c9).

Files Patch % Lines
crates/renderer/src/app.rs 0.00% 16 Missing ⚠️
crates/core/src/skia/skia_renderer.rs 0.00% 8 Missing ⚠️
crates/testing/src/test_handler.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
- Coverage   73.81%   73.74%   -0.08%     
==========================================
  Files         200      200              
  Lines       20955    20975      +20     
==========================================
  Hits        15468    15468              
- Misses       5487     5507      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review July 13, 2024 12:01
@marc2332 marc2332 merged commit 9ffa035 into main Jul 13, 2024
6 of 7 checks passed
@marc2332 marc2332 deleted the fix/prevent-opacity-from-clipping-the-node-bounds branch July 13, 2024 14:19
This was referenced Jul 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Opacity attribute prevents shadows rendering correctly.
1 participant