Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support space-between/space-around/space-evenly alignments #758

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jul 1, 2024

No description provided.

@marc2332 marc2332 added enhancement 🔥 New feature or request layout 📐 Relate to layout labels Jul 1, 2024
@marc2332 marc2332 changed the title feat: Support space-between/space-around/space-evenly for align… feat: Support space-between/space-around/space-evenly alignments Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

Benchmark for 74d042d

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 114.6±1.87ms 114.2±2.60ms -0.35%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 28.9±1.24ms 29.9±1.48ms +3.46%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1482.2±11.89µs 1512.6±86.39µs +2.05%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 141.7±1.36µs 143.7±1.36µs +1.41%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 27.1±0.94ms 28.9±0.93ms +6.64%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1855.5±222.20µs 2.2±0.28ms +18.57%
benchmarks/size=19531 depth=7 wide=5 mode=cached 383.9±83.69µs 336.7±31.67µs -12.29%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.8±0.16ms 2.8±0.12ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 420.9±49.76µs 431.7±82.59µs +2.57%
benchmarks/size=54241 depth=5 wide=15 mode=cached 299.0±44.41µs 471.4±111.13µs +57.66%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 7.1±0.41ms 7.7±0.83ms +8.45%

Copy link

github-actions bot commented Jul 1, 2024

Benchmark for a3a16cc

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 108.0±0.42ms 110.1±0.44ms +1.94%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.3±0.43ms 24.3±0.78ms 0.00%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1442.0±119.92µs 1483.2±11.07µs +2.86%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 141.2±4.14µs 144.4±0.81µs +2.27%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.1±0.26ms 23.3±0.33ms +0.87%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1724.7±33.99µs 1723.8±86.17µs -0.05%
benchmarks/size=19531 depth=7 wide=5 mode=cached 310.0±4.38µs 310.6±3.31µs +0.19%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.7±0.20ms 2.7±0.01ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 424.5±134.77µs 423.8±113.32µs -0.16%
benchmarks/size=54241 depth=5 wide=15 mode=cached 245.8±21.61µs 247.5±9.91µs +0.69%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.5±0.30ms 6.7±0.34ms +3.08%

Copy link

github-actions bot commented Jul 1, 2024

Benchmark for a0c9a6a

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 109.3±1.12ms 110.9±1.14ms +1.46%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.1±0.42ms 28.4±0.72ms +17.84%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1455.0±103.74µs 1606.7±10.77µs +10.43%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 141.6±0.88µs 156.9±1.96µs +10.81%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 23.2±0.21ms 25.4±0.33ms +9.48%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1714.2±32.31µs 1781.4±68.91µs +3.92%
benchmarks/size=19531 depth=7 wide=5 mode=cached 308.4±8.33µs 311.7±4.48µs +1.07%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.01ms 2.7±0.06ms +3.85%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 420.2±133.97µs 426.2±131.82µs +1.43%
benchmarks/size=54241 depth=5 wide=15 mode=cached 253.2±20.61µs 269.3±36.83µs +6.36%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.5±0.06ms 7.0±0.33ms +7.69%

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 92.87834% with 24 lines in your changes missing coverage. Please review.

Project coverage is 73.89%. Comparing base (6c72898) to head (12b7091).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/torin/src/geometry.rs 64.00% 18 Missing ⚠️
crates/core/src/skia/skia_measurer.rs 0.00% 3 Missing ⚠️
crates/torin/src/values/alignment.rs 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   73.57%   73.89%   +0.31%     
==========================================
  Files         199      199              
  Lines       20397    20729     +332     
==========================================
+ Hits        15008    15318     +310     
- Misses       5389     5411      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review July 1, 2024 17:55
Copy link

github-actions bot commented Jul 1, 2024

Benchmark for d2a4da6

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 109.3±0.49ms 111.6±0.70ms +2.10%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 26.4±0.91ms 27.0±1.03ms +2.27%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1429.1±21.71µs 1486.4±8.24µs +4.01%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 141.1±3.01µs 144.7±0.81µs +2.55%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 26.0±0.57ms 25.8±0.50ms -0.77%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1703.5±5.37µs 1785.2±48.07µs +4.80%
benchmarks/size=19531 depth=7 wide=5 mode=cached 312.4±3.23µs 328.5±8.49µs +5.15%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.8±0.08ms 2.9±0.05ms +3.57%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 419.6±38.71µs 424.0±4.48µs +1.05%
benchmarks/size=54241 depth=5 wide=15 mode=cached 289.2±31.48µs 296.8±34.26µs +2.63%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.5±0.07ms 6.9±0.28ms +6.15%

@marc2332 marc2332 merged commit 6de16ee into main Jul 9, 2024
8 checks passed
@marc2332 marc2332 deleted the feat/space-between-around-evenly branch July 9, 2024 19:44
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
This was referenced Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request layout 📐 Relate to layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant