Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only send left mouseover event when not clicking the mouse #753

Merged

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jun 29, 2024

Winit only emits mouseover events when (case 1) the cursor is inside the window or (case 2) when the cursor is outside the window, but a click event was initiated inside the window.

This PR fixes a bug where the left mouseover was being emitted even in case 2.

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 73.56%. Comparing base (6c72898) to head (7a45034).

Files Patch % Lines
crates/renderer/src/renderer.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   73.57%   73.56%   -0.02%     
==========================================
  Files         199      199              
  Lines       20397    20400       +3     
==========================================
  Hits        15008    15008              
- Misses       5389     5392       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit 1955629 into main Jul 6, 2024
6 of 7 checks passed
@marc2332 marc2332 deleted the fix/only-send-left-mouseover-event-when-not-clicking-mouse branch July 6, 2024 08:09
This was referenced Jul 6, 2024
This was referenced Jul 16, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant