Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move rendering to freya-core #712

Merged
merged 3 commits into from
Jun 15, 2024

Conversation

marc2332
Copy link
Owner

Cleans up code and also makes it possible for #702

@marc2332 marc2332 added the internal impovement👍 Internal code improvements label Jun 15, 2024
Copy link

Benchmark for e758383

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 107.7±2.09ms 109.0±0.45ms +1.21%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.8±1.77ms 26.3±1.83ms +6.05%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1478.6±37.77µs 1516.9±22.86µs +2.59%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 138.1±1.29µs 142.2±1.31µs +2.97%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.4±0.89ms 24.6±0.36ms +0.82%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1726.6±69.81µs 1763.5±26.74µs +2.14%
benchmarks/size=19531 depth=7 wide=5 mode=cached 310.7±4.11µs 358.4±14.05µs +15.35%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.7±0.05ms 2.7±0.10ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 420.2±133.10µs 422.8±146.01µs +0.62%
benchmarks/size=54241 depth=5 wide=15 mode=cached 252.8±16.92µs 298.9±32.48µs +18.24%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.6±0.18ms 6.7±0.44ms +1.52%

@marc2332 marc2332 changed the title refactor: Move rendering to freya core refactor: Move rendering to freya-core Jun 15, 2024
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 132 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@3070eae). Learn more about missing BASE report.

Files Patch % Lines
crates/core/src/skia/skia_renderer/renderer.rs 0.00% 105 Missing ⚠️
crates/renderer/src/app.rs 0.00% 25 Missing ⚠️
crates/core/src/render.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage        ?   74.04%           
=======================================
  Files           ?      196           
  Lines           ?    20395           
  Branches        ?        0           
=======================================
  Hits            ?    15101           
  Misses          ?     5294           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit ab083e0 into main Jun 15, 2024
4 checks passed
@marc2332 marc2332 deleted the refactor/move-rendering-to-freya-core branch June 15, 2024 12:57
This was referenced Jun 26, 2024
This was referenced Jul 6, 2024
This was referenced Jul 16, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
@github-actions github-actions bot mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal impovement👍 Internal code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant