Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More reliable devtools #667

Merged
merged 6 commits into from
Jun 10, 2024
Merged

feat: More reliable devtools #667

merged 6 commits into from
Jun 10, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jun 8, 2024

Depends on #657

@marc2332 marc2332 added enhancement 🔥 New feature or request performance ⚡️ Performance improvement ⚡️ labels Jun 8, 2024
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 200 lines in your changes missing coverage. Please review.

Project coverage is 74.01%. Comparing base (5c0f452) to head (f61ca6b).
Report is 2 commits behind head on main.

Current head f61ca6b differs from pull request most recent head 4b6b514

Please upload reports for the commit 4b6b514 to get more accurate results.

Files Patch % Lines
crates/devtools/src/tabs/style.rs 0.00% 87 Missing ⚠️
crates/renderer/src/devtools.rs 0.00% 42 Missing ⚠️
crates/devtools/src/lib.rs 0.00% 34 Missing ⚠️
crates/devtools/src/tabs/tree.rs 0.00% 15 Missing ⚠️
crates/devtools/src/hooks/use_node_info.rs 0.00% 7 Missing ⚠️
crates/freya/src/launch.rs 0.00% 6 Missing ⚠️
crates/renderer/src/app.rs 0.00% 6 Missing ⚠️
crates/renderer/src/lib.rs 0.00% 2 Missing ⚠️
crates/devtools/src/node.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
+ Coverage   73.90%   74.01%   +0.10%     
==========================================
  Files         194      195       +1     
  Lines       19951    19922      -29     
==========================================
  Hits        14745    14745              
+ Misses       5206     5177      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/persisted-devtools-routing to main June 10, 2024 19:29
* feat: Persist devtools node inspector routing

* clippy
@marc2332 marc2332 merged commit f7e72cd into main Jun 10, 2024
4 checks passed
@marc2332 marc2332 deleted the feat/more-reliable-devtools branch June 10, 2024 19:39
This was referenced Jun 17, 2024
This was referenced Jun 21, 2024
This was referenced Jun 29, 2024
This was referenced Jul 6, 2024
This was referenced Jul 16, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request performance ⚡️ Performance improvement ⚡️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant