Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use single position cursor #653

Merged
merged 7 commits into from
Jun 2, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jun 2, 2024

Less and simpler code!

@marc2332 marc2332 added the internal impovement👍 Internal code improvements label Jun 2, 2024
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 82.97872% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 73.90%. Comparing base (b84b961) to head (7e4a5a0).

Files Patch % Lines
crates/hooks/src/text_editor.rs 82.05% 14 Missing ⚠️
crates/hooks/src/use_editable.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   73.90%   73.90%   -0.01%     
==========================================
  Files         194      194              
  Lines       19968    19912      -56     
==========================================
- Hits        14758    14715      -43     
+ Misses       5210     5197      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit 47fe4da into main Jun 2, 2024
7 checks passed
@marc2332 marc2332 deleted the refactor/use-single-position-cursor branch June 2, 2024 16:26
This was referenced Jun 2, 2024
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
This was referenced Jun 26, 2024
This was referenced Jul 6, 2024
This was referenced Jul 16, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal impovement👍 Internal code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant