Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Revamp internal text selection #647

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Jun 1, 2024

Fixes #623

@marc2332 marc2332 added enhancement 🔥 New feature or request fix 🩹 Fixes a bug performance ⚡️ Performance improvement ⚡️ labels Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 75.75758% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 73.40%. Comparing base (2671d6f) to head (65d8885).

Files Patch % Lines
crates/hooks/src/use_editable.rs 78.57% 12 Missing ⚠️
crates/hooks/src/text_editor.rs 15.38% 11 Missing ⚠️
crates/renderer/src/app.rs 0.00% 4 Missing ⚠️
crates/hooks/src/rope_editor.rs 88.46% 3 Missing ⚠️
crates/renderer/src/event_loop.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #647   +/-   ##
=======================================
  Coverage   73.40%   73.40%           
=======================================
  Files         194      194           
  Lines       19580    19583    +3     
=======================================
+ Hits        14372    14375    +3     
  Misses       5208     5208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 merged commit bf08123 into main Jun 1, 2024
7 checks passed
@marc2332 marc2332 deleted the feat/revamp-internal-text-selection branch June 1, 2024 21:07
This was referenced Jun 1, 2024
This was referenced Jun 26, 2024
This was referenced Jun 29, 2024
This was referenced Jul 6, 2024
This was referenced Jul 16, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request fix 🩹 Fixes a bug performance ⚡️ Performance improvement ⚡️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Performances goes down the more text you highlight
1 participant