Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reactive Platform data #635

Merged
merged 16 commits into from
Jun 1, 2024
Merged

feat: Reactive Platform data #635

merged 16 commits into from
Jun 1, 2024

Conversation

marc2332
Copy link
Owner

Closes #634
Depends on #631

dload0 and others added 9 commits May 27, 2024 15:15
When the `WindowDragArea` component received a non-left click, the drag area would become disabled, even when receiving standard right click events.

Fixed by adding a check in the `onmousedown` function within the component.
@marc2332 marc2332 added the enhancement 🔥 New feature or request label May 30, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 56.11511% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 73.00%. Comparing base (128b962) to head (7142337).
Report is 6 commits behind head on main.

Current head 7142337 differs from pull request most recent head eb930f0

Please upload reports for the commit eb930f0 to get more accurate results.

Files Patch % Lines
crates/renderer/src/app.rs 0.00% 25 Missing ⚠️
crates/core/src/platform_state.rs 23.07% 10 Missing ⚠️
crates/renderer/src/event_loop.rs 0.00% 5 Missing ⚠️
crates/hooks/src/use_theme.rs 0.00% 4 Missing ⚠️
crates/renderer/src/accessibility.rs 0.00% 4 Missing ⚠️
crates/hooks/src/use_preferred_theme.rs 0.00% 3 Missing ⚠️
crates/testing/src/test_handler.rs 76.92% 3 Missing ⚠️
crates/devtools/src/lib.rs 0.00% 2 Missing ⚠️
crates/freya/src/launch.rs 0.00% 2 Missing ⚠️
crates/hooks/src/use_init_native_platform.rs 95.45% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   73.00%   73.00%   -0.01%     
==========================================
  Files         192      194       +2     
  Lines       19151    19172      +21     
==========================================
+ Hits        13981    13996      +15     
- Misses       5170     5176       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 changed the title feat: Reactive window data feat: Reactive paltform data May 31, 2024
@marc2332 marc2332 changed the title feat: Reactive paltform data feat: Reactive Platform data May 31, 2024
@marc2332 marc2332 marked this pull request as ready for review May 31, 2024 21:37
@marc2332 marc2332 linked an issue May 31, 2024 that may be closed by this pull request
Base automatically changed from feat/preferred-theme to main June 1, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Reactive Platform data
2 participants