Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix performance dropping rapidly after selecting a text for some time #624

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

marc2332
Copy link
Owner

Take the cursor position and selections the moment it is measured instead of received by use_editable to avoid unnecessary measurements

Closes #623

… instead of received by `use_editable` to avoid unnecessary measurements
@marc2332 marc2332 added fix 🩹 Fixes a bug performance ⚡️ Performance improvement ⚡️ labels May 26, 2024
@marc2332 marc2332 self-assigned this May 26, 2024
Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 98.85057% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.14%. Comparing base (128b962) to head (25ae711).
Report is 1 commits behind head on main.

Current head 25ae711 differs from pull request most recent head 4437181

Please upload reports for the commit 4437181 to get more accurate results.

Files Patch % Lines
crates/core/src/dom/doms.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
+ Coverage   73.00%   73.14%   +0.14%     
==========================================
  Files         192      192              
  Lines       19151    19091      -60     
==========================================
- Hits        13981    13965      -16     
+ Misses       5170     5126      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review May 26, 2024 15:06
@marc2332 marc2332 merged commit f27206b into main Jun 1, 2024
6 checks passed
@marc2332 marc2332 deleted the fix/performance-goes-down-as-text-is-highlighted branch June 1, 2024 13:59
This was referenced Jun 17, 2024
This was referenced Jun 29, 2024
This was referenced Jul 6, 2024
This was referenced Jul 16, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Fixes a bug performance ⚡️ Performance improvement ⚡️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Performances goes down the more text you highlight
1 participant