Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose scale factor #607

Merged
merged 3 commits into from
Jun 10, 2024
Merged

feat: Expose scale factor #607

merged 3 commits into from
Jun 10, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented May 9, 2024

Closes #605
Depends on #606

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 9.64286% with 759 lines in your changes missing coverage. Please review.

Project coverage is 73.11%. Comparing base (4e4d5c3) to head (30a5be1).
Report is 2 commits behind head on main.

Current head 30a5be1 differs from pull request most recent head cde6552

Please upload reports for the commit cde6552 to get more accurate results.

Files Patch % Lines
crates/renderer/src/renderer.rs 0.00% 524 Missing ⚠️
crates/renderer/src/render.rs 0.00% 105 Missing ⚠️
crates/renderer/src/app.rs 0.00% 38 Missing ⚠️
crates/renderer/src/config.rs 0.00% 36 Missing ⚠️
crates/renderer/src/elements/rect.rs 0.00% 16 Missing ⚠️
crates/renderer/src/accessibility.rs 0.00% 13 Missing ⚠️
crates/freya/src/launch.rs 0.00% 7 Missing ⚠️
crates/state/src/font_style.rs 40.00% 6 Missing ⚠️
crates/state/src/layout.rs 71.42% 4 Missing ⚠️
crates/common/src/event_messages.rs 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   74.26%   73.11%   -1.15%     
==========================================
  Files         194      190       -4     
  Lines       20267    19239    -1028     
==========================================
- Hits        15051    14067     -984     
+ Misses       5216     5172      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review May 15, 2024 19:23
@marc2332 marc2332 linked an issue May 16, 2024 that may be closed by this pull request
@marc2332 marc2332 force-pushed the feat/react-to-scale-factor-changes branch from 1c75fd3 to 4e4d5c3 Compare June 10, 2024 21:02
@marc2332 marc2332 force-pushed the feat/expose-scale-factor branch from 30a5be1 to f5d5f02 Compare June 10, 2024 21:11
Base automatically changed from feat/react-to-scale-factor-changes to main June 10, 2024 21:11
@marc2332 marc2332 merged commit 18e4f88 into main Jun 10, 2024
3 checks passed
@marc2332 marc2332 deleted the feat/expose-scale-factor branch June 10, 2024 21:12
This was referenced Jun 18, 2024
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
This was referenced Jun 26, 2024
This was referenced Jul 6, 2024
This was referenced Jul 16, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Expose scale factor in PlatformInformation
1 participant