Merge 77f8a4c into fcfc482

marc2332 · Aug 18, 2024 · 72105d7 · 72105d7
2 parents fcfc482 + 77f8a4c
commit 72105d7
Show file tree

Hide file tree

Showing 7 changed files with 677 additions and 738 deletions.
diff --git a/crates/torin/src/dom_adapter.rs b/crates/torin/src/dom_adapter.rs
@@ -46,7 +46,7 @@ impl PartialEq for LayoutNode {
 impl LayoutNode {
     // The area without any margin
     pub fn visible_area(&self) -> Area {
-        self.area.after_gaps(&self.margin)
+        self.area.without_gaps(&self.margin)
     }
 }
 

diff --git a/crates/torin/src/geometry.rs b/crates/torin/src/geometry.rs
@@ -1,11 +1,8 @@
-use crate::{
-    node::Node,
-    prelude::{
-        Alignment,
-        DirectionMode,
-        Gaps,
-        Size,
-    },
+use crate::prelude::{
+    DirectionMode,
+    Gaps,
+    Node,
+    Size,
 };
 
 #[derive(PartialEq)]
@@ -18,157 +15,37 @@ pub type CursorPoint = euclid::Point2D<f64, Measure>;
 pub type Length = euclid::Length<f32, Measure>;
 
 pub trait AreaModel {
-    // The area without any outer gap (e.g margin)
-    fn after_gaps(&self, margin: &Gaps) -> Area;
+    /// The area without any outer gap (e.g margin)
+    fn without_gaps(self, gap: &Gaps) -> Area;
 
-    // Adjust the available area with the node offsets (mainly used by scrollviews)
+    /// Adjust the available area with the node offsets (mainly used by scrollviews)
     fn move_with_offsets(&mut self, offset_x: &Length, offset_y: &Length);
 
-    // Align the content of this node.
-    fn align_content(
-        &mut self,
-        available_area: &Area,
-        contents_area: &Size2D,
-        alignment: &Alignment,
-        direction: &DirectionMode,
-        alignment_direction: AlignmentDirection,
-    );
-
-    // Align the position of this node.
-    #[allow(clippy::too_many_arguments)]
-    fn align_position(
-        &mut self,
-        initial_available_area: &Area,
-        inner_sizes: &Size2D,
-        alignment: &Alignment,
-        direction: &DirectionMode,
-        alignment_direction: AlignmentDirection,
-        siblings_len: usize,
-        child_position: usize,
-    );
-
+    /// Adjust the size given the Node data
     fn adjust_size(&mut self, node: &Node);
 }
 
 impl AreaModel for Area {
-    /// Get the area inside after including the gaps (margins or paddings)
-    fn after_gaps(&self, margin: &Gaps) -> Area {
+    #[inline]
+    fn without_gaps(self, gaps: &Gaps) -> Area {
         let origin = self.origin;
         let size = self.size;
         Area::new(
-            Point2D::new(origin.x + margin.left(), origin.y + margin.top()),
+            Point2D::new(origin.x + gaps.left(), origin.y + gaps.top()),
             Size2D::new(
-                size.width - margin.horizontal(),
-                size.height - margin.vertical(),
+                size.width - gaps.horizontal(),
+                size.height - gaps.vertical(),
             ),
         )
     }
 
-    /// Get the area inside after including the gaps (margins or paddings)
+    #[inline]
     fn move_with_offsets(&mut self, offset_x: &Length, offset_y: &Length) {
         self.origin.x += offset_x.get();
         self.origin.y += offset_y.get();
     }
 
-    fn align_content(
-        &mut self,
-        available_area: &Area,
-        contents_size: &Size2D,
-        alignment: &Alignment,
-        direction: &DirectionMode,
-        alignment_direction: AlignmentDirection,
-    ) {
-        let axis = get_align_axis(direction, alignment_direction);
-
-        match axis {
-            AlignAxis::Height => match alignment {
-                Alignment::Center => {
-                    let new_origin_y =
-                        (available_area.height() / 2.0) - (contents_size.height / 2.0);
-
-                    self.origin.y = available_area.min_y() + new_origin_y;
-                }
-                Alignment::End => {
-                    self.origin.y = available_area.max_y() - contents_size.height;
-                }
-                _ => {}
-            },
-            AlignAxis::Width => match alignment {
-                Alignment::Center => {
-                    let new_origin_x = (available_area.width() / 2.0) - (contents_size.width / 2.0);
-
-                    self.origin.x = available_area.min_x() + new_origin_x;
-                }
-                Alignment::End => {
-                    self.origin.x = available_area.max_x() - contents_size.width;
-                }
-                _ => {}
-            },
-        }
-    }
-
-    fn align_position(
-        &mut self,
-        initial_available_area: &Area,
-        inner_sizes: &Size2D,
-        alignment: &Alignment,
-        direction: &DirectionMode,
-        alignment_direction: AlignmentDirection,
-        siblings_len: usize,
-        child_position: usize,
-    ) {
-        let axis = get_align_axis(direction, alignment_direction);
-
-        match axis {
-            AlignAxis::Height => match alignment {
-                Alignment::SpaceBetween if child_position > 0 => {
-                    let all_gaps_sizes = initial_available_area.height() - inner_sizes.height;
-                    let gap_size = all_gaps_sizes / (siblings_len - 1) as f32;
-                    self.origin.y += gap_size;
-                }
-                Alignment::SpaceEvenly => {
-                    let all_gaps_sizes = initial_available_area.height() - inner_sizes.height;
-                    let gap_size = all_gaps_sizes / (siblings_len + 1) as f32;
-                    self.origin.y += gap_size;
-                }
-                Alignment::SpaceAround => {
-                    let all_gaps_sizes = initial_available_area.height() - inner_sizes.height;
-                    let one_gap_size = all_gaps_sizes / siblings_len as f32;
-                    let gap_size = if child_position == 0 || child_position == siblings_len {
-                        one_gap_size / 2.
-                    } else {
-                        one_gap_size
-                    };
-                    self.origin.y += gap_size;
-                }
-                _ => {}
-            },
-            AlignAxis::Width => match alignment {
-                Alignment::SpaceBetween if child_position > 0 => {
-                    let all_gaps_sizes = initial_available_area.width() - inner_sizes.width;
-                    let gap_size = all_gaps_sizes / (siblings_len - 1) as f32;
-                    self.origin.x += gap_size;
-                }
-                Alignment::SpaceEvenly => {
-                    let all_gaps_sizes = initial_available_area.width() - inner_sizes.width;
-                    let gap_size = all_gaps_sizes / (siblings_len + 1) as f32;
-                    self.origin.x += gap_size;
-                }
-                Alignment::SpaceAround => {
-                    let all_gaps_sizes = initial_available_area.width() - inner_sizes.width;
-                    let one_gap_size = all_gaps_sizes / siblings_len as f32;
-                    let gap_size = if child_position == 0 || child_position == siblings_len {
-                        one_gap_size / 2.
-                    } else {
-                        one_gap_size
-                    };
-                    self.origin.x += gap_size;
-                }
-                _ => {}
-            },
-        }
-    }
-
+    #[inline(always)]
     fn adjust_size(&mut self, node: &Node) {
         if let Size::InnerPercentage(p) = node.width {
             self.size.width *= p.get() / 100.;
@@ -179,22 +56,6 @@ impl AreaModel for Area {
     }
 }
 
-pub fn get_align_axis(
-    direction: &DirectionMode,
-    alignment_direction: AlignmentDirection,
-) -> AlignAxis {
-    match direction {
-        DirectionMode::Vertical => match alignment_direction {
-            AlignmentDirection::Main => AlignAxis::Height,
-            AlignmentDirection::Cross => AlignAxis::Width,
-        },
-        DirectionMode::Horizontal => match alignment_direction {
-            AlignmentDirection::Main => AlignAxis::Width,
-            AlignmentDirection::Cross => AlignAxis::Height,
-        },
-    }
-}
-
 pub enum AlignmentDirection {
     Main,
     Cross,
@@ -205,3 +66,31 @@ pub enum AlignAxis {
     Height,
     Width,
 }
+
+impl AlignAxis {
+    #[inline]
+    pub fn new(direction: &DirectionMode, alignment_direction: AlignmentDirection) -> Self {
+        match direction {
+            DirectionMode::Vertical => match alignment_direction {
+                AlignmentDirection::Main => AlignAxis::Height,
+                AlignmentDirection::Cross => AlignAxis::Width,
+            },
+            DirectionMode::Horizontal => match alignment_direction {
+                AlignmentDirection::Main => AlignAxis::Width,
+                AlignmentDirection::Cross => AlignAxis::Height,
+            },
+        }
+    }
+}
+
+pub trait SizeModel {
+    /// Get the size with the given gap, e.g padding.
+    fn with_gaps(self, gap: &Gaps) -> Size2D;
+}
+
+impl SizeModel for Size2D {
+    #[inline]
+    fn with_gaps(self, gap: &Gaps) -> Size2D {
+        Size2D::new(self.width + gap.horizontal(), self.height + gap.vertical())
+    }
+}
diff --git a/crates/torin/src/lib.rs b/crates/torin/src/lib.rs
@@ -2,7 +2,6 @@ pub mod custom_measurer;
 pub mod dom_adapter;
 pub mod geometry;
 mod measure;
-mod measure_mode;
 pub mod node;
 pub mod scaled;
 pub mod torin;