Showing unused class after class is added back.

[Kcharle]

VS Code - Version 1.28.2 (1.28.2)

When I save, the file instantly highlights the unused class as expected, but when I then undo to add the class back, and save, the unused warning is still there until I click on another file and go back, or close the file an reopen it.

Thoughts?

[marabesi]

currently the extension does not automatically refresh once the class is added back.

I am trying to work on it asap, but a PR is welcome as well.

[marabesi]

@Kcharle I've changed a bit the code to support the feature you requested, would you mind to have a look at it?

136eaf9

[Acr0most]

@marabesi In my opinion you trigger the function highlightSelections every time your regex matches.
So you generate the decorations for every single match - but for the hole "range"-array. Which means the decorations will be generated multiple times.

I would push the ranges only on the array and set the decorations only one time.

Then you don't need some specific function for decoration. You just need ranges.push() instead of highlightSelections(editor, [new vscode.Range(startPos, endPos)]); and after your while (match = regEx.exec(text)) you can trigger editor.setDecorations(unusedNamespaceDecorationType, ranges);once.

[marabesi]

@Acr0most I Understood you point but I couldn't make it though. Is there a snippet or something for me to look at?

[Acr0most]

@marabesi simply two changes:

actual code:

 while (match = regEx.exec(text)) {
            let splitNameSpace = match[1].split('\\');
            let className = splitNameSpace[splitNameSpace.length - 1];

            if (className.search(/ as /) > -1 ) {
                let splitAlias = className.split(' as ');
                className = splitAlias[splitAlias.length - 1].trim();
            }

            let found = (text.match(new RegExp(className, 'g')) || []).length;

            const startPos = editor.document.positionAt(match.index);
            const endPos = editor.document.positionAt(match.index + match[0].length);

            if (match[0].length && found < 2) {
                highlightSelections(editor, [new vscode.Range(startPos, endPos)]);
            }
        }

could be:

while (match = regEx.exec(text)) {
            let splitNameSpace = match[1].split('\\');
            let className = splitNameSpace[splitNameSpace.length - 1];

            if (className.search(/ as /) > -1 ) {
                let splitAlias = className.split(' as ');
                className = splitAlias[splitAlias.length - 1].trim();
            }

            let found = (text.match(new RegExp(className, 'g')) || []).length;

            const startPos = editor.document.positionAt(match.index);
            const endPos = editor.document.positionAt(match.index + match[0].length);

            if (match[0].length && found < 2) {
		        ranges.push(new vscode.Range(startPos, endPos));
            }
        }

        highlightSelections(editor, ranges);

EDIT: my comment above was little wrong, because you only trigger your function for a new array with only the actual match. But i think working with one array and only triggering highlight once will be little more logical.

[marabesi]

I think I got it, so your code would remove the .forEach that highlight the imports, right?

[Acr0most]

Right.
And the command to highlight unused imports will be only triggered once and not every time your regex matches.