Return subscription for on method
#5080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
I also replaced a lot of the "done" in the tests, still like 150 to go, but I'm slowly removing them... |
themustafaomar
added a commit
to themustafaomar/libregl
that referenced
this pull request
Jan 3, 2025
Leverage the new method unsubscribe method by maplibre/maplibre-gl-js#5080
themustafaomar
added a commit
to themustafaomar/libregl
that referenced
this pull request
Jan 4, 2025
## Update MapLibre to v5, for more information please visist https://github.com/maplibre/maplibre-gl-js/releases/tag/v5.0.0 * refactor: move WebGL context options to canvasContextAttributes * refactor: leverage unsubscribe method to unsubscribe events Leverage the new method unsubscribe method by maplibre/maplibre-gl-js#5080 * feat(controls): add globe control Add the GlobeControl control by maplibre/maplibre-gl-js#4960 * fix: remove the hard coded position at globe control * feat: add elevation and centerClampedToGround props * chore: update maplibre-gl to v5 * chore(playground): add controls example * build: update pnpm lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the return value of
onmethod from being chainable to something that returns a subscription that allows to unsubscribe easily.CHANGELOG.mdunder the## mainsection.