Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CSS media query to better detect touch devices #5053

Merged

Conversation

timsluis
Copy link
Contributor

@timsluis timsluis commented Nov 15, 2024

This pull request addresses an issue where the MobileHelpText for cooperative gestures is incorrectly displayed when a map is embedded in an iFrame with a width smaller than 480px, even if the user is on a desktop device.

This PR closes #5052

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

@timsluis
Copy link
Contributor Author

@HarelM Do we need/should I write a test for this?

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!

@HarelM
Copy link
Collaborator

HarelM commented Nov 15, 2024

Since this is a trivial CSS change I don't see a lot of value adding a test here...

@HarelM HarelM enabled auto-merge (squash) November 15, 2024 11:47
@HarelM HarelM merged commit 798a549 into maplibre:main Nov 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect cooperative gestures help text in iFrames
2 participants