add sky/fog expect tests to sky2 branch #3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
THANKS! |
HarelM
added a commit
that referenced
this pull request
Jun 27, 2024
* copy code from old sky branch, but this branch is not ready yet * add missing _fogMatrixCache clearance * change long comment from // to /** */ syntax * serialize sky in map.getStyle() * add sky/fog expect tests (#3649) * fix sky2 calculateFogMatrix error and build error (#3651) * try to fix calculateFogMatrix error * Raise expectedBytes for maplibre-gl.js size * Update test/build/min.test.ts * Update diff function to take into consideration sky, updated tests * Move gl logic to draw_sky file, added tests to cover serialization. * Update docs comment * Add missing tests to map.test.ts * Remove unneeded member variable * Fix build * Add cache to draw sky mesh buffer * Use globe's mesh idea, store mesh in sky object, similar to how it is done with buckets. * Fix tests * Fix names according to new spec * Fix render and build tests * Changed name to sky-horizon-blend * Fix lint * Add support for blend in fog and horizon * Terrain fog blending improvements (#4314) * Incorporate my own feedback * Fix shader * Make terrain fog shader blending gamma-correct, update render test * Move surface_color_linear into the branch * Added a debug page, fixed a bug * Update the example to show the values in the spec. * Added test to reproduce the issue * Move sky test to a different folder * Fix lint * Remove unneeded reference from example * Always initialize sky, remove ifs, fix tests * Update CHANGELOG.md * Expect build to fail due to missing image in examples * Fix docs build * Fix docs build * Compress image * Update readme --------- Co-authored-by: Max Demmelbauer <[email protected]> Co-authored-by: Andrew Calcutt <[email protected]> Co-authored-by: Harel M <[email protected]> Co-authored-by: Jakub Pelc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds expect tests for sky and fog to the sky2 branch
I added two expect tests
test\integration\render\tests\terrain\fog
test\integration\render\tests\terrain\sky
