chore: Switch to Foundry (SC-4852) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #4852: [erc20] Update repo to use forge. |
4 tasks
lucas-manuel
suggested changes
Mar 1, 2022
contracts/test/ERC20.t.sol
Outdated
| @@ -93,7 +93,7 @@ contract ERC20Test is DSTest { | |||
| } | |||
| } | |||
|
|
|||
| function proveFail_transfer_insufficientBalance(address to, uint256 mintAmount, uint256 sendAmount) public { | |||
| function testFail_transfer_insufficientBalance(address to, uint256 mintAmount, uint256 sendAmount) public { | |||
There was a problem hiding this comment.
lets update these to use vm.expectRevert
There was a problem hiding this comment.
Also lets just fuzz one amount and use the edge case
.github/workflows/pull-request.yml
Outdated
| run: forge update | ||
|
|
||
| - name: Run forge tests | ||
| run: ./test.sh -r 100000 |
There was a problem hiding this comment.
Need to use foundry.toml and profiles - refer to rdt
lucas-manuel
added
Priority: High
Status: Revisions Needed
and removed
Status: Ready for Review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrations Checklist
Changelog
Function Signature Changes
Features
Events