Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add implementation and testing #1

Merged
merged 18 commits into from
Aug 25, 2021

Conversation

lucas-manuel
Copy link

No description provided.

@lucas-manuel lucas-manuel self-assigned this Aug 22, 2021
@lucas-manuel lucas-manuel force-pushed the add-implementation-and-testing branch from 55dd1e4 to e0ad3d9 Compare August 22, 2021 20:19
feat: update README, Natspec, formatting
@lucas-manuel lucas-manuel force-pushed the add-implementation-and-testing branch from e0ad3d9 to 6debbb2 Compare August 22, 2021 20:20
@lucas-manuel lucas-manuel force-pushed the add-implementation-and-testing branch from 10c032e to d6f7f48 Compare August 23, 2021 02:24
src/ERC20.sol Outdated
}

/*********************************/
/*** ERC-20 External Functions ***/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the ERC-20 prefix is needed here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Remove.

src/ERC20.sol Outdated
}

/*********************************/
/*** ERC-20 External Functions ***/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Remove.

Copy link
Contributor

@deluca-mike deluca-mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERC20User is not functional

Copy link
Contributor

@deluca-mike deluca-mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a more functional ERC20User

@lucas-manuel lucas-manuel merged commit d1cdeea into main Aug 25, 2021
@lucas-manuel lucas-manuel deleted the add-implementation-and-testing branch August 25, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants