Added option to lock/unlock all other layers #1883
Conversation
… selected one. Works similar to show/hide all layers function
| } | ||
|
|
||
| undoStack->endMacro(); | ||
| } |
There was a problem hiding this comment.
Insert a new line at the end.
| @@ -125,6 +125,11 @@ MapDocumentActionHandler::MapDocumentActionHandler(QObject *parent) | |||
| mActionToggleOtherLayers->setIcon( | |||
| QIcon(QLatin1String(":/images/16x16/show_hide_others.png"))); | |||
|
|
|||
| mActionToggleLockOtherLayers = new QAction(this); | |||
| mActionToggleLockOtherLayers->setShortcut(tr("Ctrl+Shift+U")); | |||
There was a problem hiding this comment.
I guess Ctrl+Shift+U was chosen because Ctrl+Shift+L is already taken by "Save All"? I wonder if it wouldn't be more intuitive to use Ctrl+Shift+L here and maybe drop the "Save All" shortcut again (or switch that one to Ctrl+Alt+S, which is what Notepad++ uses).
There was a problem hiding this comment.
Yes I had put the shortcut to Ctrl+Shift+L first. I agree with your suggestion.
There was a problem hiding this comment.
Sorry, we can have only one Ctrl+Shift+S shortcut, and now it means both "Save As" and "Save All" (in which case neither will trigger). Please change "Save As" to Ctrl+Alt+S.
There was a problem hiding this comment.
Hi Bjorn, I can not see that Save As has the Ctrl+Shift+S shortcut. Have I overlooked it somewhere?
There was a problem hiding this comment.
Yes, it happens in this line, because Ctrl+Shift+S is a common shortcut for "Save As":
mUi->actionSaveAs->setShortcuts(QKeySequence::SaveAs);Changed shortcut for "Toggle Lock other Layers" to Ctrl+Shift+L
I chose to fix the code instead of the documentation, since I think this is the behavior that is generally expected. If any not-locked layers are found, all layers should get locked, since that is the primary action. Unlocking happens only when all other layers are currently locked.
|
Thanks for this useful addition! |
Added option to lock/unlock all other layers except for the currently selected one. Works similar to show/hide all layers function.