-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for methods from map.h and tileset.h for the Python plugin API. #1867
Conversation
What problems are those exactly? On Arch Linux, I have installed |
I have the same error. With PyBindGen (0.18.0).
Traceback:
|
Hmm, I get this error as well with PyBindGen 0.18.0. With 0.17 it worked fine, so you can either look for the problem or downgrade to PyBindGen 0.17. I'll try to look into this soon. |
Added copy constructors where needed for the code generation to work with pybindgen 0.18.0 (somehow it worked with pybindgen 0.17.0 without these, maybe the check is new). See pull request #1867
@yashgandhe666 @harindu95 Issues should be fixed in change da9ba8f. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashgandhe666 I've rebased your change on latest master so now it contains the fix for the above problem. However, it now raises the following issue:
pybindgen.typehandlers.base.TypeLookupError: ['QPoint']
You will probably need to define this class (currently only QPointF
and QSizeF
are defined, which you could base QPoint
and QSize
on).
src/plugins/python/tiledbinding.py
Outdated
#cls_tileset.add_method('tileOffset', 'QPoint', []) | ||
cls_tileset.add_method('tileOffset', 'QPoint', []) | ||
cls_tileset.add_method('gridSize', 'Qsize', []) | ||
cls_tileset.add_method('setGridSize', None, ('Qsize', 'gridSize')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be QSize
(though currently this class is not defined, nor is QPoint
, which is probably why the tileOffset
method is commented out).
@yashgandhe666 In my last update I've used PyBindGen 0.18 to update the generated file. Please make sure you're using 0.18 as well, to avoid the huge differences in the generated file between 0.17 and 0.18. |
Having problems with generating pythonbind.cpp