-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build 1.10.0 #3613
Comments
There is no default Qt, it just picks whatever is in your path or Qbs profile. The release notes meant the binaries I'm releasing have been updated to Qt 6. But Tiled should still compile fine against Qt 5.12 or higher as well. Regarding the error, it says "WARNING: Could not find any qmake executables in PATH". Could you check whether there is a qmake in the PATH? If there isn't, then either the package providing qmake needs to be installed, or you might try to use |
Ah I did this locally already but forgot to push. But even with qmake present it still doesn't build due to the other errors. It's those Might be that I need to use Qt5 libs? Because it looks now its kind of some mix with qmake-qt5? I'm no Qt expert.. |
The problem starts earlier, it's that one:
According to your list of dependencies, you're trying to compile Tiled against Qt 6, but in the PATH there is a Qt 5 It could be that the Qt 6 qmake has a different name. In that case, you may need to run the |
Yes, this is what I meant above with mixing. For some reason I can't find a I wasn't yet able to find somebody who explain to me why we don't have a Seems like the best would be if I drop the Qt6 dependencies and go back to Qt5 and then can use the qmake-qt5. |
Aha, I have the right dependency already added |
at https://build.opensuse.org/package/live_build_log/games:tools/tiled/openSUSE_Tumbleweed/x86_64 |
Could it be that you're somehow missing a C++ compiler? It seems it may only have found a C compiler. Edit: Not likely, judging by the line Maybe try:
Using the expected path to the |
I guess for some reason qbs detects and tries to use |
Right, in that case running |
Thanks guys, that was it. |
@jubalh That's great! And thank you for maintaining the openSUSE Tiled package! :-) |
@bjorn is there a specific thing I need to pass to qbs to install |
@jubalh The install path for tiled/src/libtiled/libtiled.qbs Lines 205 to 213 in 06c0d8b
So, at the moment there is unfortunately no option to have it install to So for packaging Tiled 1.10, I think your only option is to patch up the relevant parts of the Qbs files. For future releases, I can add appropriate options to the top-level project for convenience. Just let me know exactly what options you need. |
I used: Index: tiled-1.10.0/src/libtiled/libtiled.qbs
===================================================================
--- tiled-1.10.0.orig/src/libtiled/libtiled.qbs
+++ tiled-1.10.0/src/libtiled/libtiled.qbs
@@ -209,7 +209,7 @@ DynamicLibrary {
else
return "bin"
else
- return "lib"
+ return "lib64"
}
fileTagsFilter: "dynamiclibrary"
} Which placed the one lib into |
For that one you'd need to patch up this part: tiled/src/tiled/libtilededitor.qbs Lines 604 to 612 in 06c0d8b
That would require patching up this part: tiled/qbs/imports/TiledPlugin.qbs Lines 39 to 46 in 06c0d8b
|
Thanks! |
Since Qbs 1.13, Application and DynamicLibrary items have convenient "install" and "installDir" properties. Added products.Tiled.libDir option, which can be used to change the directory libraries are installed to. This is useful for openSUSE packaging (and possibly Fedora), which like to put 64-bit libraries in a lib64 directory (see issue #3613).
Since Qbs 1.13, Application and DynamicLibrary items have convenient "install" and "installDir" properties. Added projects.Tiled.libDir option, which can be used to change the directory libraries are installed to. This is useful for openSUSE packaging (and possibly Fedora), which like to put 64-bit libraries in a lib64 directory (see issue #3613).
I noticed the Fedora package is using the following hack, btw: mkdir -p %{buildroot}%{_libdir}
[ "%{buildroot}%{_prefix}/lib" = "%{buildroot}%{_libdir}" ] || mv -v %{buildroot}%{_prefix}/lib/* %{buildroot}%{_libdir} (edit: which needs to be combined with their patch, to make sure Tiled still finds its plug-ins) However, I have now also just finished adding an option which can be used like |
Since Qbs 1.13, Application and DynamicLibrary items have convenient "install" and "installDir" properties. Added projects.Tiled.libDir option, which can be used to change the directory libraries are installed to. This is useful for openSUSE packaging (and possibly Fedora), which like to put 64-bit libraries in a lib64 directory (see issue #3613).
I fail to build the latest 1.10.0 release with Qt6.
Note:
The readme still lists Qt5 deps only. Are the build instructions up to date? The release notes sound like Qt6 should be default now.
You can see my build recipe here: https://build.opensuse.org/package/view_file/games:tools/tiled/tiled.spec?expand=1
And the result here: https://build.opensuse.org/package/live_build_log/games:tools/tiled/openSUSE_Tumbleweed/x86_64
I get a various errors like:
Even though qt6-core-devel >= 6.4.2 is required in the spec file.
Any hints would be welcome.
The text was updated successfully, but these errors were encountered: