Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some small lifetime issues with moderately big implications. Currently, code like this fails:
The compiler complains with:
This is due to the declaration of
impl ExactSizeIterator
functions:Which, expanded, look like this:
Which limit the lifetime of the iterator and its items to the mapwrapper object. This is not required because the mapwrapper object is just a reference tuple, and so these functions should be like this:
This PR fixes these issues and enforces the fix with some doctests.