Make path a requirement for parsing tilesets #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleokdev
changed the title
bjorn
reviewed
Feb 14, 2022
bjorn
previously approved these changes
Feb 23, 2022
aleokdev
force-pushed
the
better-tileset
branch
from
fdad760 to
6559594
Compare
aleokdev
force-pushed
the
better-tileset
branch
from
77ea1b3 to
8820065
Compare
bjorn
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR heavily simplifies tileset creation by making the root path a requirement, even if it is not used, and also removes the
SourceRequirederror. While this does force full-embedded tileset users* to usePathBuf::default()as the path instead ofNone, the internal simplifications make up for that extra allocation.*Note: Since this crate does not support embedded images yet (The Tiled editor doesn't either), we can safely assume that those users do not exist.