Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return non-zero exit code when given images differ #54

Merged
merged 6 commits into from
Feb 15, 2019
Merged

Return non-zero exit code when given images differ #54

merged 6 commits into from
Feb 15, 2019

Conversation

maio
Copy link
Contributor

@maio maio commented Feb 14, 2019

So that caller of this script can decide what to do based on diff result.

maio added 4 commits February 14, 2019 15:26
@maio
Return non-zero exit code when given images differ
b904294 
So that caller of this script can decide what to do based on diff result.
@maio
Fix typo
666e778
@maio
Disable no-process-exit eslint rule in bin/pixelmatch
349c108
@maio
Wait for write operation to finish before exiting
b1d2c8f 
Otherwise resulting file may get corrupted.
mourner
mourner approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good apart from the missing semicolon that fails the build.

@maio
Copy link
Contributor Author

maio commented Feb 15, 2019

Thanks for quick review @mourner. It should be fixed now.

@mourner mourner merged commit 8a5683b into mapbox:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maio @mourner