Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapbox maps SDK for Android v6.7.0 #728

Merged
merged 5 commits into from
Nov 8, 2018
Merged

Mapbox maps SDK for Android v6.7.0 #728

merged 5 commits into from
Nov 8, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Oct 19, 2018 •
edited by LukasPaczos
Loading

This PR is part of our QA process upstream in GL-native:

  • alpha.1
  • alpha.2
  • beta.1
  • final

@tobrun tobrun self-assigned this Oct 19, 2018
@LukasPaczos
Copy link
Contributor

When testing 6.7.0-beta.1 and 7.0.0-SNAPSHOT, I spotted the following upstream issues - mapbox/mapbox-gl-native#13284, mapbox/mapbox-gl-native#13285, mapbox/mapbox-gl-native#13287.

@LukasPaczos LukasPaczos self-requested a review November 8, 2018 13:45
@LukasPaczos LukasPaczos mentioned this pull request Nov 8, 2018
Closed
@LukasPaczos
Copy link
Contributor

Heads up that recently changed map state callbacks upstream impacted the deprecated LocationLayerPlugin that it crashes on startup, because of the additional OnDidFinishLoadingStyle call. For now, I'm ignoring the plugin's test suite and we can move forward with removing the codebase entirely soon, possibly leaving plugin's main page as a reference, not to break existing links.

A note, that the LocationLayerPlugins's codebase has already been moved to the mapbox-gl-native repository and the same funtionality is available with the LocationComponent shipped with the Maps SDK for Android.

@LukasPaczos LukasPaczos merged commit 30ccf2d into master Nov 8, 2018
@LukasPaczos LukasPaczos deleted the maps-release-6.7.0 branch November 8, 2018 14:20
@LukasPaczos LukasPaczos mentioned this pull request Nov 9, 2018
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Assignees

@tobrun tobrun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobrun @LukasPaczos