Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localization.md #881

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Update localization.md #881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions localization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
| Language | User interface | Mapbox Voice API | Android TextToSpeech
|------------|:--------------:|:----------------:|:---------------------:
| Catalan | - | — | —
| Chinese | - | ✅ | —
| Chinese | - | ✅ | ✅
| Danish | - | ✅ | ✅
| Dutch | - | ✅ | ✅
| English | ✅ | ✅ | ✅
| French | - | ✅ | ✅
| German | - | ✅ | ✅
| Hebrew | - | ✅ | —
| Hebrew | - | - | —
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implies that Hebrew voice instructions are unsupported. But in fact the Directions API does produce Hebrew instructions, and this Stack Overflow answer implies that at least some Android devices do support Hebrew in the Android TTS engine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ec5 I was looking at that answer earlier. The accepted answer seems incorrect, as it's showing usage of Locale#getAvailableLocales which seems unfortunately unrelated to Locales that are actually supported by Android TextToSpeech

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to track down actual confirmation that TextToSpeech does support Hebrew

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find either. Apparently "Google Translate" doesn't support voice for Hebrew language either https://www.quora.com/Why-doesnt-Google-Translate-support-voice-for-Hebrew-Language

| Hungarian | - | — | ✅
| Italian | - | ✅ | ✅
| Portuguese | - | ✅ | ✅
Expand Down