Remove use of LiveData for fetching DirectionsRoute and updating Location #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
force-pushed
the
dan-consolidate-vm
branch
2 times, most recently
from
38f7d63 to
aefe7e8
Compare
|
@Guardiola31337 @devotaaabel would love some eyes here for possible suggestions on how to make |
danesfeder
force-pushed
the
dan-consolidate-vm
branch
from
093d0b7 to
68978e5
Compare
|
@Guardiola31337 @devotaaabel okay this is ready for 👀 - if you have some better ideas for tests, please leave them as feedback. Confirmed re-routes are occurring successfully in the background 🚀 I decided to create some instrumentation tests as well, but because this PR is so big, I'm going to create a follow up PR to address this. |
danesfeder
changed the title
danesfeder
force-pushed
the
dan-consolidate-vm
branch
from
ab9592c to
96cd589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #750
We currently use
LiveDatato update newDirectionsRoutes (such as an off-route event) andLocationupdates (previouslyRouteViewModelandLocationViewModel).This PR removes these vm's and replaces them with classes that has callbacks and can operate in the background without issue.
TODO:
NavigationCamera