-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[location-component] Add isLocatedAt API to location component plugin. #99
Conversation
1ed2450
to
4fc3cc7
Compare
...ponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationComponentPluginImpl.kt
Outdated
Show resolved
Hide resolved
...ponent/src/main/java/com/mapbox/maps/plugin/locationcomponent/LocationComponentPluginImpl.kt
Outdated
Show resolved
Hide resolved
4fc3cc7
to
e93db26
Compare
...base/src/main/java/com/mapbox/maps/plugin/locationcomponent/IsPointOnLocationPuckListener.kt
Outdated
Show resolved
Hide resolved
@tobrun @kiryldz I renamed the following:
to
Please take a second look before I merge. |
635cb05
to
a2f9a5e
Compare
Personally do not like that |
…tener to PuckLocatedAtPointListener.
a2f9a5e
to
66b83c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-android
changelog:<changelog></changelog>
.Summary of changes
This PR adds the
isPointOnLocationPuck
API to the location component plugin, it can be used to validate if a MapClicked event is invoked on top of the location component puck.User impact (optional)