Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example activity of creating MapView #85

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Add example activity of creating MapView #85

merged 1 commit into from
Feb 8, 2021

Conversation

kiryldz
Copy link
Contributor

@kiryldz kiryldz commented Feb 8, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: #83
<changelog>Add example activity of creating MapView</changelog>

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog></changelog>.

Summary of changes

User impact (optional)

@kiryldz kiryldz requested a review from a team February 8, 2021 12:07
@kiryldz kiryldz self-assigned this Feb 8, 2021
@kiryldz kiryldz requested a review from Chaoba February 8, 2021 13:42
@kiryldz kiryldz force-pushed the kdz-map-view-programatically-example branch from bdf09d9 to 5f8302b Compare February 8, 2021 13:42
@kiryldz kiryldz force-pushed the kdz-map-view-programatically-example branch from 5f8302b to a9aec1f Compare February 8, 2021 13:56
@kiryldz kiryldz requested a review from pengdev February 8, 2021 13:58
Chaoba
Chaoba approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@Chaoba Chaoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiryldz kiryldz merged commit c1282bc into main Feb 8, 2021
@kiryldz kiryldz deleted the kdz-map-view-programatically-example branch February 8, 2021 16:54
@maratsct maratsct mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengdev pengdev pengdev approved these changes

@Chaoba Chaoba Chaoba approved these changes

Assignees

@kiryldz kiryldz

Labels
feature 🍏
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare example of creating MapView programatically
3 participants
@kiryldz @pengdev @Chaoba