Allow getCameraOptions with no padding parameter #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengdev
reviewed
Jan 22, 2021
| @@ -18,7 +18,7 @@ interface MapTransformDelegate { | |||
| * | |||
| * @param edgeInsets The optional padding | |||
| */ | |||
| fun getCameraOptions(edgeInsets: EdgeInsets?): CameraOptions | |||
| fun getCameraOptions(edgeInsets: EdgeInsets? = null): CameraOptions | |||
There was a problem hiding this comment.
Do we also need to add the default value to the MapboxMap override funtion?
There was a problem hiding this comment.
Kotlin does not allow doing that.
However I've checked it's handled OK like it's done now.
There was a problem hiding this comment.
Please update description to remove link to private repo.
pengdev
approved these changes
Jan 22, 2021
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<changelog>Allow getCameraOptions with no padding parameter</changelog>