[deps] Bump gl-native to v10.0.0-beta.17, common to v10.0.2, minSdkVersion to 21, and address breaking changes. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiryldz
reviewed
Mar 16, 2021
kiryldz
reviewed
Mar 16, 2021
kiryldz
reviewed
Mar 17, 2021
kiryldz
reviewed
Mar 17, 2021
kiryldz
reviewed
Mar 17, 2021
| * | ||
| * Observable will hold a strong reference to an Observer instance, therefore, | ||
| * in order to stop receiving notifications, caller must call unsubscribe with an | ||
| * Observer instance used for an initial subscription. | ||
| * | ||
| * @param observer an Observer | ||
| */ | ||
| fun ObservableInterface.subscribeMapLoadingFinished(observer: Observer) = | ||
| subscribe(observer, listOf(MapEvents.MAP_LOADING_FINISHED)) | ||
| fun ObservableInterface.subscribeMapLoaded(observer: Observer) = |
There was a problem hiding this comment.
nit but
do we have an example somewhere of how to use that extension?
I think may be reasonable adding in some example activity.
There was a problem hiding this comment.
We have one example in DebugModeActivity, but it doesn't cover all the events. We should make a new example for both the listeners and observer approach.
pengdev
force-pushed
the
peng-bump-gl-native-beta.17
branch
from
f8d626c to
dae7b6e
Compare
pengdev
force-pushed
the
peng-bump-gl-native-beta.17
branch
from
dae7b6e to
0b87915
Compare
|
Verified that the style-test bot is green, merging to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Change logs:
Bump minSdkVersion of the SDK is bumped to 21, and bumped okhttp dependency to v4.9.0.
Rename
jumpTo(options: CameraOptions)tosetCamera(options: CameraOptions), renamesetFreeCameraOptions (options: FreeCameraOptions)tosetCamera(options: FreeCameraOptions).Rename
OnMapLoadingFinishedListenertoOnMapLoadedListener.Introduce
OnStyleDataLoadedListenerto replaceOnStyleLoadingFinishedListener, and introduceOnSourceDataLoadedListenerto replaceOnSourceChangedListener. So that developers have granular control of style/source loading status.Introduce
coordinateBoundsForCamera()API to replace thegetBounds()API.Schedule non-rendering tasks on Android's scheduler to improve render performance.
Pull request checklist:
mapbox-maps-androidchangelog:<changelog></changelog>.Summary of changes
This PR introduces many breaking changes to the SDK:
jumpTo(options: CameraOptions)tosetCamera(options: CameraOptions), renamedsetFreeCameraOptions (options: FreeCameraOptions)tosetCamera(options: FreeCameraOptions).OnMapLoadingFinishedListenertoOnMapLoadedListener.OnStyleDataLoadedListenerto replaceOnStyleLoadingFinishedListener, and introducedOnSourceDataLoadedListenerto replaceOnSourceChangedListenerAPI to have granular control of style/source loading status.coordinateBoundsForCamera()API to replace thegetBounds()APIUser impact (optional)