Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[style-extension] Rename reference to style plugin and converting them to style extension. #123

Merged
merged 1 commit into from
Feb 23, 2021
Merged

[style-extension] Rename reference to style plugin and converting them to style extension. #123

merged 1 commit into from
Feb 23, 2021

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented Feb 23, 2021 •
edited
Loading

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Rename reference to style plugin and converting them to style extension.</changelog>.

Summary of changes

This PR renames reference to style plugin and converting them to style extension.

User impact (optional)

@pengdev pengdev self-assigned this Feb 23, 2021
@pengdev pengdev requested a review from a team February 23, 2021 12:41
@pengdev pengdev force-pushed the peng-fix-referring-to-style-plugin branch from e1bc892 to d82a070 Compare February 23, 2021 12:45
@pengdev pengdev closed this Feb 23, 2021
@pengdev pengdev reopened this Feb 23, 2021
@pengdev pengdev force-pushed the peng-fix-referring-to-style-plugin branch from d82a070 to ef132f2 Compare February 23, 2021 12:51
@pengdev pengdev force-pushed the peng-fix-referring-to-style-plugin branch from ef132f2 to 169f8fe Compare February 23, 2021 12:57
kiryldz
kiryldz approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

@pengdev pengdev merged commit 6fbada4 into main Feb 23, 2021
@pengdev pengdev deleted the peng-fix-referring-to-style-plugin branch February 23, 2021 13:30
@maratsct maratsct mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiryldz kiryldz kiryldz approved these changes

Assignees

@pengdev pengdev

Labels
docs 📜
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pengdev @kiryldz