[Compass plugin] Hidden the compass if facing north; apply the opacity correctly. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaoba
force-pushed
the
kl-compass-visiable
branch
from
b4d63f0 to
734734a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: #41
Pull request checklist:
mapbox-maps-androidchangelog:<changelog>[Compass plugin] Hidden the compass if facing north; apply the opacity correctly.</changelog>.Summary of changes
This pr will hide the compass while opening a map that faces north.
In the past, the opacity will change from 1.0 to 0.0 while the compass is hiding even user sets the compass opacity, this pr fix this issue too.
User impact (optional)