Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gradle in MAS 2.x.x #716

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Update Gradle in MAS 2.x.x #716

merged 1 commit into from
Mar 1, 2018

Conversation

Guardiola31337
Copy link
Contributor

  • Updates MAS 2.x.x to Gradle 4.1 and Gradle tools 3.0

Needed to fix mapbox/mapbox-gl-native#11125

👀 @LukasPaczos @tobrun @zugaldia @lilykaiser

@Guardiola31337 Guardiola31337 self-assigned this Feb 8, 2018
@Guardiola31337 Guardiola31337 mentioned this pull request Feb 9, 2018
Closed
@Guardiola31337
Copy link
Contributor Author

Although mapbox/mapbox-gl-native#10920 fixed the transitive dependencies with Gradle 4.x issue (mapbox/mapbox-gl-native#11125 (comment)) I'm going to leave this PR opened because it's not harmful and even could be necessary to avoid regressions if we need to publish a new version of MAS 2.x

@Guardiola31337
Copy link
Contributor Author

Actually mapbox/mapbox-gl-native#10920 didn't fix the transitive dependencies with Gradle 4.x issue (mapbox/mapbox-gl-native#11125 (comment)). mapbox/mapbox-gl-native#11161 did.

Although this PR wasn't needed to fix mapbox/mapbox-gl-native#11125 going to leave the PR opened anyways.

@cammace
Copy link

cammace commented Feb 26, 2018

Although this PR wasn't needed to fix mapbox/mapbox-gl-native#11125 going to leave the PR opened anyways.

do we still want to merge this or can we close?

@Guardiola31337
Copy link
Contributor Author

do we still want to merge this or can we close?

I'd personally merge it if you don't have any push back. It's not harmful and could be useful for future 2.x requests.

@Guardiola31337 Guardiola31337 force-pushed the pg-mas-2.x.x-upgrade-gradle branch from 331e1e9 to c2d7b2b Compare March 1, 2018 17:35
@cammace cammace merged commit 62cfaec into mas-2.x.x Mar 1, 2018
@cammace cammace deleted the pg-mas-2.x.x-upgrade-gradle branch March 1, 2018 17:53
@Guardiola31337
Copy link
Contributor Author

  • Bumped mapbox dependency to 5.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammace cammace cammace approved these changes

@zugaldia zugaldia Awaiting requested review from zugaldia

@tobrun tobrun Awaiting requested review from tobrun

@LukasPaczos LukasPaczos Awaiting requested review from LukasPaczos

Assignees

@Guardiola31337 Guardiola31337

Labels
Bug Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Guardiola31337 @cammace