Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

specify strictness of filter operators #194

Closed
jfirebaugh opened this issue Oct 26, 2014 · 4 comments
Closed

specify strictness of filter operators #194

jfirebaugh opened this issue Oct 26, 2014 · 4 comments
Milestone

Comments

@jfirebaugh
Copy link
Contributor

If the property value type does not match the filter value type, specify what happens for each operator type.

@jfirebaugh
Copy link
Contributor Author

I'm implementing strict operators for v6 filters. 0 == '0', 0 < '1', 0 in ['0'], etc. will all return false for both js and native. This was previously inconsistent between the two, with JS being strict in == and != where native was not. Both were relaxed for less/greater than operators but I don't see a good reason to do so and it significantly complicates the native implementation.

@nickidlugash @edenh @tmcw @mourner Any objections?

@edenh
Copy link
Contributor

edenh commented Oct 28, 2014

👍

1 similar comment
@nickidlugash
Copy link
Contributor

👍

@kkaefer
Copy link
Member

kkaefer commented Oct 28, 2014

reason for being lazy is bad data in vector tiles when numbers were encoded as strings, but I think most of those instances are gone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants