Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[Android][WIP] Refactor my location view #7516

Closed
wants to merge 8 commits into from
Closed

Conversation

cammace
Copy link
Contributor

@cammace cammace commented Dec 21, 2016

The user location has been suffering from a few bugs since it is a view placed on top of map.

Closes: #6084
Closes: #4799
Closes: #2564?
Closes: #7086
Closes: #7349?
Closes: #6768?
Closes: #6765?
Closes: #6167
Closes: #6138

This PR attempts to refactor mainly the locationView to instead use runtime styling on the map.

ezgif com-video-to-gif 3

A few things are left to bring this implementation up to par with what the current my location view offers, mainly tracking, animation between new user location positions, and customization of the colors.

@cammace cammace added Android Mapbox Maps SDK for Android refactor ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold labels Dec 21, 2016
@cammace cammace added this to the android-v5.0.0 milestone Dec 21, 2016
@cammace cammace self-assigned this Dec 21, 2016
@mention-bot
Copy link

@cammace, thanks for your PR! By analyzing this pull request, we identified @zugaldia, @tmcw and @ansis to be potential reviewers.

@cammace cammace changed the title [Android] Refactor my location view [Android][WIP] Refactor my location view Dec 21, 2016
@cammace
Copy link
Contributor Author

cammace commented Jan 4, 2017

Customization of user location icon:
ezgif com-video-to-gif 2

User location compass (Not sure what is causing the flickering):
ezgif com-video-to-gif 1

Stale user location:
ezgif com-video-to-gif

@zugaldia
Copy link
Member

zugaldia commented Jan 4, 2017

@cammace Looking fantastic.

@cammace
Copy link
Contributor Author

cammace commented Jan 17, 2017

This implementation is currently blocked after discovering that consistently calling turf.circle while animating the user location to a new position produces major lagging on the map. The ideal fix for this will be once circle-pitch-alignment is implemented in the style spec (currently being tracked in mapbox/mapbox-gl-style-spec#459).

@zugaldia
Copy link
Member

zugaldia commented Feb 3, 2017

@cammace Looking at the list of tickets this PR could potentially close, though I understand mapbox/mapbox-gl-style-spec#459 is a blocker for full implementation, would it be possible to land partial progress with this PR (closing those tickets that don't depend on circle-pitch-alignment) and leave the rest for a separate PR?

@cammace
Copy link
Contributor Author

cammace commented Feb 3, 2017

I'll look into this beginning of next week, I think some issues have already been resolved such as this flickering issue:

https://cloud.githubusercontent.com/assets/5652865/21627666/61722fb0-d1e7-11e6-89cf-fa8ceb98909e.gif

which was fixed recently with #7615

@cammace
Copy link
Contributor Author

cammace commented May 10, 2017

Closing in favor of mapbox/mapbox-plugins-android#22

@cammace cammace closed this May 10, 2017
@jfirebaugh jfirebaugh deleted the cam-user-loc-refactor branch May 11, 2017 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants