-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Android][WIP] Refactor my location view #7516
Conversation
@cammace Looking fantastic. |
This implementation is currently blocked after discovering that consistently calling turf.circle while animating the user location to a new position produces major lagging on the map. The ideal fix for this will be once |
@cammace Looking at the list of tickets this PR could potentially close, though I understand mapbox/mapbox-gl-style-spec#459 is a blocker for full implementation, would it be possible to land partial progress with this PR (closing those tickets that don't depend on |
I'll look into this beginning of next week, I think some issues have already been resolved such as this flickering issue: https://cloud.githubusercontent.com/assets/5652865/21627666/61722fb0-d1e7-11e6-89cf-fa8ceb98909e.gif which was fixed recently with #7615 |
Closing in favor of mapbox/mapbox-plugins-android#22 |
The user location has been suffering from a few bugs since it is a view placed on top of map.
Closes: #6084
Closes: #4799
Closes: #2564?
Closes: #7086
Closes: #7349?
Closes: #6768?
Closes: #6765?
Closes: #6167
Closes: #6138
This PR attempts to refactor mainly the locationView to instead use runtime styling on the map.
A few things are left to bring this implementation up to par with what the current my location view offers, mainly tracking, animation between new user location positions, and customization of the colors.