This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Convert GeoJSON features to tiles in background #15871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
added
performance
pozdnyakov
added
the
needs changelog
LukasPaczos
reviewed
Oct 30, 2019
Composing tiles from the GeoJSON features is an expensive operation that might block UI thread on updating the `GeoJsonSource` with the new data. This change moves tile composing to the background thread and thus unblocks the UI thread.
pozdnyakov
force-pushed
the
mikhail_geojson_to_vt_in_background
branch
from
085e1d1 to
18e9331
Compare
pozdnyakov
removed
the
needs changelog
LukasPaczos
approved these changes
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composing tiles from the GeoJSON features is an expensive operation that might block UI thread on updating the
GeoJsonSourcewith the new data.This change moves tile composing to the background thread and thus unblocks the UI thread.
Fixes: https://github.com/mapbox/mapbox-gl-native-team/issues/87
Tag: #8484