Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Fix the crash when CameraPosition padding is set. #15699

Merged
merged 2 commits into from
Sep 23, 2019
Merged

[android] Fix the crash when CameraPosition padding is set. #15699

merged 2 commits into from
Sep 23, 2019

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented Sep 23, 2019

Resolves #15693

@pengdev pengdev added the Android Mapbox Maps SDK for Android label Sep 23, 2019
@pengdev pengdev self-assigned this Sep 23, 2019
@pengdev pengdev force-pushed the peng-fix-camera-padding branch from 363b73c to 38e5a2c Compare September 23, 2019 13:07
@pengdev pengdev changed the title Fix the crash when CameraPosition padding is set. [android] Fix the crash when CameraPosition padding is set. Sep 23, 2019
tobrun
tobrun approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the MapSnapshotterActivity has a sanity test, I'm calling this use-case covered with a test.

@pengdev pengdev merged commit 426da3a into master Sep 23, 2019
@pengdev pengdev deleted the peng-fix-camera-padding branch September 23, 2019 16:11
langsmith pushed a commit that referenced this pull request Sep 25, 2019
@pengdev
[android] Fix the crash when CameraPosition padding is set. (#15699)
b1d9774 
* [android] Add test branch, navigate to Map Snapshotter activity to reproduce the bug.

* [android] Fix the crash when camera position padding is set.
@langsmith langsmith mentioned this pull request Sep 25, 2019
Merged
langsmith pushed a commit that referenced this pull request Sep 25, 2019
[android] cherry pick of snapshot padding (15623) and feedback form (…
60c44d8 
…15699) to ristretto (#15714)

* [android] Migrate Android SDK to GL JS–powered feedback form (#15623)

* [android] Fix the crash when CameraPosition padding is set. (#15699)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

@LukasPaczos LukasPaczos Awaiting requested review from LukasPaczos

Assignees

@pengdev pengdev

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CameraPosition is crashing when paddings are set
2 participants
@pengdev @tobrun