This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Document that LocationComponentOptions.elevation(0) turns off the shadow. #14471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @zestyping, LGTM! Could you rebase on |
Merged
|
I've rebased this PR in #14723, thanks again @zestyping! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocationComponentOptions provides ways to set the foreground and background drawable, but no way to set the shadow drawable. The JavaDoc for LocationComponentOptions doesn't mention the word "shadow" at all, so it seems as though there is no way to turn off the shadow.
But it is possible to turn off the shadow by setting the elevation to zero. This PR just adds that explanation to the
elevation()method.