Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Do not include CJK ideographs in the offline packs by default #14269

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Do not include CJK ideographs in the offline packs by default #14269

merged 2 commits into from
Jul 31, 2019

Conversation

LukasPaczos
Copy link
Contributor

Closes #14201.

/cc @ChrisLoer :)

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Mar 29, 2019
@LukasPaczos LukasPaczos added this to the release-m milestone Mar 29, 2019
@LukasPaczos LukasPaczos requested a review from tobrun March 29, 2019 12:19
@LukasPaczos
Copy link
Contributor Author

Currently blocked by #14271.

@LukasPaczos LukasPaczos added the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Mar 29, 2019
@LukasPaczos LukasPaczos removed this from the release-mojito milestone May 16, 2019
@stale stale bot added the archived Archived because of inactivity label Jul 15, 2019
@stale
Copy link

stale bot commented Jul 15, 2019

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this Jul 15, 2019
@LukasPaczos LukasPaczos reopened this Jul 15, 2019
@stale stale bot removed the archived Archived because of inactivity label Jul 15, 2019
@LukasPaczos LukasPaczos mentioned this pull request Jul 30, 2019
Merged
@LukasPaczos LukasPaczos force-pushed the lp-offline-packs-ideographs-14201 branch from e26a44e to 9bb4ba9 Compare July 30, 2019 12:03
@LukasPaczos LukasPaczos removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Jul 30, 2019
@LukasPaczos
Copy link
Contributor Author

This is ready for a review.

/cc @Chaoba @chloekraw

@LukasPaczos LukasPaczos added this to the release-queso milestone Jul 30, 2019
@Chaoba
Copy link
Contributor

Chaoba commented Jul 31, 2019

Both of these two classes not add includeIdeographs in writeToParcel method, can you add it?
BTW, why does OfflineRegionDefinition need extends Parcelable?

@LukasPaczos
Copy link
Contributor Author

@Chaoba I believe it's required for the offline plugin.

@Chaoba
Copy link
Contributor

Chaoba commented Jul 31, 2019

LGTM

@LukasPaczos LukasPaczos added the needs changelog Indicates PR needs a changelog entry prior to merging. label Jul 31, 2019
@LukasPaczos LukasPaczos merged commit 703c76a into master Jul 31, 2019
@LukasPaczos LukasPaczos deleted the lp-offline-packs-ideographs-14201 branch July 31, 2019 09:12
@LukasPaczos LukasPaczos removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
release-queso
Development

Successfully merging this pull request may close these issues.

Exclude CJK resources from offline download by default
3 participants
@LukasPaczos @Chaoba @tobrun