This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Register compass sensor listener only if necessary #13573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
, thank you for all the tests
LukasPaczos
force-pushed
the
lp-activate-compass-only-when-consumed
branch
from
9c40a3e to
86f0f46
Compare
danesfeder
approved these changes
Dec 13, 2018
…onsumed by the location layer or location camera
LukasPaczos
force-pushed
the
lp-activate-compass-only-when-consumed
branch
from
86f0f46 to
8b53198
Compare
|
@LukasPaczos Awesome! |
This was referenced Dec 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register compass sensor listener only if provided data is consumed by the location layer or location camera. The idea here is to remove the overhead of creating new compass animators when they are ultimately ignored.
/cc @BharathMG